From 514266d48aa564daa9949d15b3651b898ed73903 Mon Sep 17 00:00:00 2001 From: bethanyj28 Date: Mon, 26 Feb 2024 09:36:35 -0500 Subject: [PATCH 1/2] ensure callback is only called once --- src/internal/download/download-artifact.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/internal/download/download-artifact.ts b/src/internal/download/download-artifact.ts index 09890c2..2880c53 100644 --- a/src/internal/download/download-artifact.ts +++ b/src/internal/download/download-artifact.ts @@ -128,10 +128,7 @@ export async function streamExtractExternal( if (!createdDirectories.has(path.dirname(fullPath))) { createdDirectories.add(path.dirname(fullPath)) await resolveOrCreateDirectory(path.dirname(fullPath)).then( - () => { - entry.autodrain() - callback() - } + () => {} ) } From 74542ecfb8ba324d1fde81c5e60221394b1b0e12 Mon Sep 17 00:00:00 2001 From: bethanyj28 Date: Mon, 26 Feb 2024 09:56:00 -0500 Subject: [PATCH 2/2] feedback --- src/internal/download/download-artifact.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/internal/download/download-artifact.ts b/src/internal/download/download-artifact.ts index 2880c53..c30d65f 100644 --- a/src/internal/download/download-artifact.ts +++ b/src/internal/download/download-artifact.ts @@ -127,9 +127,7 @@ export async function streamExtractExternal( } else { if (!createdDirectories.has(path.dirname(fullPath))) { createdDirectories.add(path.dirname(fullPath)) - await resolveOrCreateDirectory(path.dirname(fullPath)).then( - () => {} - ) + await resolveOrCreateDirectory(path.dirname(fullPath)) } const writeStream = createWriteStream(fullPath)