From fc83cc9f2cfcf3845097424ae9b7692689f2084e Mon Sep 17 00:00:00 2001 From: Andrei Kashchikhin Date: Mon, 1 Sep 2025 11:52:11 +0200 Subject: [PATCH 1/3] add reject --- src/internal/download/download-artifact.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/internal/download/download-artifact.ts b/src/internal/download/download-artifact.ts index 4a735bb..1616aff 100644 --- a/src/internal/download/download-artifact.ts +++ b/src/internal/download/download-artifact.ts @@ -82,6 +82,7 @@ export async function streamExtractExternal( response.message.destroy( new Error(`Blob storage chunk did not respond in ${timeout}ms`) ) + reject(`Blob storage chunk did not respond in ${timeout}ms`) } const timer = setTimeout(timerFn, timeout) From 9f7af6f342ee60170f8c5e308c5a93cd2bd4dcfe Mon Sep 17 00:00:00 2001 From: Andrei Kashchikhin Date: Wed, 24 Sep 2025 17:05:25 +0200 Subject: [PATCH 2/3] use error in both reject and destroy --- src/internal/download/download-artifact.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/internal/download/download-artifact.ts b/src/internal/download/download-artifact.ts index 1616aff..d001a2f 100644 --- a/src/internal/download/download-artifact.ts +++ b/src/internal/download/download-artifact.ts @@ -79,10 +79,9 @@ export async function streamExtractExternal( return new Promise((resolve, reject) => { const timerFn = (): void => { - response.message.destroy( - new Error(`Blob storage chunk did not respond in ${timeout}ms`) - ) - reject(`Blob storage chunk did not respond in ${timeout}ms`) + const timeoutError = new Error(`Blob storage chunk did not respond in ${timeout}ms`) + response.message.destroy(timeoutError) + reject(timeoutError) } const timer = setTimeout(timerFn, timeout) From 4261798b6717e0277f06d880543bb1db13cb0f9e Mon Sep 17 00:00:00 2001 From: Andrei Kashchikhin Date: Thu, 25 Sep 2025 10:53:34 +0200 Subject: [PATCH 3/3] lint --- src/internal/download/download-artifact.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/internal/download/download-artifact.ts b/src/internal/download/download-artifact.ts index d001a2f..090260f 100644 --- a/src/internal/download/download-artifact.ts +++ b/src/internal/download/download-artifact.ts @@ -79,7 +79,9 @@ export async function streamExtractExternal( return new Promise((resolve, reject) => { const timerFn = (): void => { - const timeoutError = new Error(`Blob storage chunk did not respond in ${timeout}ms`) + const timeoutError = new Error( + `Blob storage chunk did not respond in ${timeout}ms` + ) response.message.destroy(timeoutError) reject(timeoutError) }