diff --git a/__tests__/test-artifact-file.sh b/__tests__/test-artifact-file.sh index 708dc80..d36d22e 100755 --- a/__tests__/test-artifact-file.sh +++ b/__tests__/test-artifact-file.sh @@ -18,8 +18,10 @@ if [ ! -f "$path" ]; then exit 1 fi -actualContent=$(cat $path) -if [ "$actualContent" != "$expectedContent" ];then +actualContent=$(cat "$path") +if [ "$expectedContent" == "_EMPTY_" ] && [ ! -s "$path" ]; then + exit 0 +elif [ "$actualContent" != "$expectedContent" ]; then echo "File contents are not correct, expected $expectedContent, received $actualContent" exit 1 fi \ No newline at end of file diff --git a/__tests__/upload.test.ts b/__tests__/upload.test.ts index 9f3ce1a..75c228e 100644 --- a/__tests__/upload.test.ts +++ b/__tests__/upload.test.ts @@ -181,7 +181,10 @@ describe('Upload Tests', () => { function hasMkfifo(): boolean { try { // make sure we drain the stdout - return execSync('which mkfifo').toString().length > 0 + return ( + process.platform !== 'win32' && + execSync('which mkfifo').toString().length > 0 + ) } catch (e) { return false } diff --git a/src/internal/upload-http-client.ts b/src/internal/upload-http-client.ts index 473f40d..9892a42 100644 --- a/src/internal/upload-http-client.ts +++ b/src/internal/upload-http-client.ts @@ -221,10 +221,7 @@ export class UploadHttpClient { ): Promise { const fileStat: fs.Stats = await stat(parameters.file) const totalFileSize = fileStat.size - // on Windows with mkfifo from MSYS2 stats.isFIFO returns false, so we check if running on Windows node and - // if the file has size of 0 to compensate - const isFIFO = - fileStat.isFIFO() || (process.platform === 'win32' && totalFileSize === 0) + const isFIFO = fileStat.isFIFO() let offset = 0 let isUploadSuccessful = true let failedChunkSizes = 0