From 96ef2e6e817ee3fbd961bfa468934570d3292bda Mon Sep 17 00:00:00 2001 From: Vallie Joseph Date: Thu, 3 Aug 2023 16:36:11 -0400 Subject: [PATCH] Audit Fix (#1480) * fixing audit failures * replacing lerna bootstrap with npm command * audit fix for cache and tool-cache * updating tunnel * upgrading core packages * re-adding tunnel as prod dep * updating dependencies * updating exec deps * updating exec io package * . * Revert * updating packages * adding core as dep * updating learna config * updating lerna commands * Removing audit failing packages in cache + tool-cache * updating contribution bootstrap description * updating libraries * prettier lint * hiding stricter rules * updating prettier command * Removing unknown flag * Adding eslint prettier * ignoring sym links * updating ignore path * updating prettier rules * changing prettier + github ver * updating ts and ignores * Revert ts * Adding unknown ignores * downgrading lerna * . * adding nx * Adding lint auto lint rules * updating eslint ignore for glob packages * Adding subdirs to ignore * adding flag for ignore pattern in linter * Expanding ignore regex * Adding ignore rules * adding another ignore pattern to tsconfig eslint * adding ignore pattern to eslintrc * syncing package-json * updating traverse * . * test adding core and http client to base package * running npm ci * adding tsconfig paths * adding base URL * Adding explicit path to core and http-client * editing tsc call * updating artifact packages * force build * updating lock file version * updating lock file version * upgrading node version * Adding babel traverse back * fixing build issue * fixing typescript ver * updating package json * Adding ignore for artifact test * adding ignore to flags * unlink after test completes * cleanup * merge + package edit --- __tests__/exec.test.ts | 6 +++--- src/toolrunner.ts | 15 +++++---------- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/__tests__/exec.test.ts b/__tests__/exec.test.ts index e2f6fc3..1f83ce4 100644 --- a/__tests__/exec.test.ts +++ b/__tests__/exec.test.ts @@ -357,7 +357,7 @@ describe('@actions/exec', () => { expect(exitCode).toBe(0) }) - it('Handles child process holding streams open', async function() { + it('Handles child process holding streams open', async function () { const semaphorePath = path.join( getTestTemp(), 'child-process-semaphore.txt' @@ -403,7 +403,7 @@ describe('@actions/exec', () => { fs.unlinkSync(semaphorePath) }, 10000) // this was timing out on some slower hosted macOS runs at default 5s - it('Handles child process holding streams open and non-zero exit code', async function() { + it('Handles child process holding streams open and non-zero exit code', async function () { const semaphorePath = path.join( getTestTemp(), 'child-process-semaphore.txt' @@ -457,7 +457,7 @@ describe('@actions/exec', () => { fs.unlinkSync(semaphorePath) }, 10000) // this was timing out on some slower hosted macOS runs at default 5s - it('Handles child process holding streams open and stderr', async function() { + it('Handles child process holding streams open and stderr', async function () { const semaphorePath = path.join( getTestTemp(), 'child-process-semaphore.txt' diff --git a/src/toolrunner.ts b/src/toolrunner.ts index 87d0bbe..18f884d 100644 --- a/src/toolrunner.ts +++ b/src/toolrunner.ts @@ -267,10 +267,7 @@ export class ToolRunner extends events.EventEmitter { } reverse += '"' - return reverse - .split('') - .reverse() - .join('') + return reverse.split('').reverse().join('') } private _uvQuoteCmdArg(arg: string): string { @@ -350,10 +347,7 @@ export class ToolRunner extends events.EventEmitter { } reverse += '"' - return reverse - .split('') - .reverse() - .join('') + return reverse.split('').reverse().join('') } private _cloneExecOptions(options?: im.ExecOptions): im.ExecOptions { @@ -691,8 +685,9 @@ class ExecState extends events.EventEmitter { } if (!state.processClosed && state.processExited) { - const message = `The STDIO streams did not close within ${state.delay / - 1000} seconds of the exit event from process '${ + const message = `The STDIO streams did not close within ${ + state.delay / 1000 + } seconds of the exit event from process '${ state.toolPath }'. This may indicate a child process inherited the STDIO streams and has not yet exited.` state._debug(message)