diff --git a/prog/plugin/main.go b/prog/plugin/main.go index 8a9c4ac9..cf6d0ad0 100644 --- a/prog/plugin/main.go +++ b/prog/plugin/main.go @@ -22,7 +22,7 @@ import ( "github.com/weaveworks/weave/plugin/skel" ) -var version = "(unreleased version)" +var version = "unreleased" var Log = common.Log diff --git a/prog/weave-kube/launch.sh b/prog/weave-kube/launch.sh index ad7ddef9..2438c3d5 100755 --- a/prog/weave-kube/launch.sh +++ b/prog/weave-kube/launch.sh @@ -19,13 +19,13 @@ fi echo 1 > /proc/sys/net/bridge/bridge-nf-call-iptables SOURCE_BINARY=/usr/bin/weaveutil -VERSION=$(/home/weave/weaver --version | sed -E 's/weave router (.*?)/\1/') +VERSION=$(/home/weave/weaver $EXTRA_ARGS --version | sed -e 's/weave router //') PLUGIN="weave-plugin-$VERSION" install_cni_plugin() { mkdir -p $1 || return 1 - if [ ! -f $1/$PLUGIN ]; then - cp "$SOURCE_BINARY" $1/$PLUGIN + if [ ! -f "$1/$PLUGIN" ]; then + cp "$SOURCE_BINARY" "$1/$PLUGIN" fi } @@ -33,7 +33,7 @@ upgrade_cni_plugin_symlink() { # Remove potential temporary symlink from previous failed upgrade: rm -f $1/$2.tmp # Atomically create a symlink to the plugin: - ln -s $1/$PLUGIN $1/$2.tmp && mv -f $1/$2.tmp $1/$2 + ln -s "$1/$PLUGIN" $1/$2.tmp && mv -f $1/$2.tmp $1/$2 } upgrade_cni_plugin() { diff --git a/prog/weave-npc/main.go b/prog/weave-npc/main.go index 58b3e994..ecc26d2a 100644 --- a/prog/weave-npc/main.go +++ b/prog/weave-npc/main.go @@ -24,7 +24,7 @@ import ( ) var ( - version = "(unreleased)" + version = "unreleased" metricsAddr string ) diff --git a/prog/weaveproxy/main.go b/prog/weaveproxy/main.go index a2688dee..d8e58b21 100644 --- a/prog/weaveproxy/main.go +++ b/prog/weaveproxy/main.go @@ -11,7 +11,7 @@ import ( "github.com/weaveworks/weave/proxy" ) -var version = "(unreleased version)" +var version = "unreleased" var Log = common.Log diff --git a/prog/weaver/main.go b/prog/weaver/main.go index 00d08de0..92cb5bba 100644 --- a/prog/weaver/main.go +++ b/prog/weaver/main.go @@ -27,7 +27,7 @@ import ( weave "github.com/weaveworks/weave/router" ) -var version = "(unreleased version)" +var version = "unreleased" var Log = common.Log diff --git a/site/troubleshooting.md b/site/troubleshooting.md index 4f67e739..b5c2d2b0 100644 --- a/site/troubleshooting.md +++ b/site/troubleshooting.md @@ -302,7 +302,7 @@ latest snapshot release using: sudo chmod a+x /usr/local/bin/weave weave setup -Snapshot releases report the script version as "(unreleased version)", +Snapshot releases report the script version as "unreleased", and the container image versions as git hashes. diff --git a/weave b/weave index dadd9b02..a4f787cc 100755 --- a/weave +++ b/weave @@ -3,9 +3,9 @@ set -e [ -n "$WEAVE_DEBUG" ] && set -x -SCRIPT_VERSION="(unreleased version)" +SCRIPT_VERSION="unreleased" IMAGE_VERSION=latest -[ "$SCRIPT_VERSION" = "(unreleased version)" ] || IMAGE_VERSION=$SCRIPT_VERSION +[ "$SCRIPT_VERSION" = "unreleased" ] || IMAGE_VERSION=$SCRIPT_VERSION IMAGE_VERSION=${WEAVE_VERSION:-$IMAGE_VERSION} # - Docker versions prior to 1.6 cannot pull images from DockerHub