From 3a0b3417700a57ade5c537f8563986cce28f6914 Mon Sep 17 00:00:00 2001
From: Ilya Dmitrichenko <errordeveloper@gmail.com>
Date: Wed, 20 May 2015 08:24:18 +0100
Subject: [PATCH] Improve readability of Vagrantfile and cleanup this official
 image

---
 Vagrantfile | 89 ++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 65 insertions(+), 24 deletions(-)

diff --git a/Vagrantfile b/Vagrantfile
index a1f702a0..0b52078d 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -1,7 +1,66 @@
 VAGRANTFILE_API_VERSION = "2"
 
 vm_ip = "172.16.0.3" # arbitrary private IP
-pkgs = "lxc-docker aufs-tools build-essential ethtool iputils-arping libpcap-dev git mercurial bc"
+
+go_version = "1.4.2"
+
+pkgs = %w(
+  lxc-docker
+  aufs-tools
+  build-essential
+  ethtool
+  iputils-arping
+  libpcap-dev
+  git
+  mercurial
+  bc
+)
+
+go_path = "/usr/local/go/bin"
+
+$install_build_deps = <<SCRIPT
+export DEBIAN_FRONTEND=noninteractive
+apt-key adv \
+  --keyserver hkp://keyserver.ubuntu.com:80 \
+  --recv-keys 36A1D7869245C8950F966E92D8576A8BA88D21E9
+echo 'deb https://get.docker.io/ubuntu docker main' \
+  > /etc/apt/sources.list.d/docker.list
+apt-get -qq update
+apt-get -qq install --no-install-recommends #{pkgs.join(' ')}
+SCRIPT
+
+$install_go_toochain = <<SCRIPT
+curl -s https://storage.googleapis.com/golang/go#{go_version}.linux-amd64.tar.gz \
+  | tar xz -C /usr/local
+#{go_path}/go clean -i net
+#{go_path}/go install -tags netgo std
+SCRIPT
+
+$tweak_user_env = <<SCRIPT
+echo 'export GOPATH="${HOME}"' \
+  >> ~vagrant/.profile
+echo 'export PATH="${HOME}/bin:#{go_path}:${PATH}"' \
+  >> ~vagrant/.profile
+ln -sf ~vagrant/src/github.com/weaveworks/weave ~vagrant/
+sudo chown -R vagrant:vagrant ~vagrant/src
+SCRIPT
+
+$tweak_docker_daemon = <<SCRIPT
+usermod -a -G docker vagrant
+echo 'DOCKER_OPTS="-H unix:///var/run/docker.sock -H tcp://0.0.0.0:2375"' \
+  >> /etc/default/docker
+service docker restart
+SCRIPT
+
+$cleanup = <<SCRIPT
+export DEBIAN_FRONTEND=noninteractive
+## Who the hell thinks official images have to have both of these?
+/etc/init.d/chef-client stop
+/etc/init.d/puppet stop
+apt-get -qq remove puppet chef
+apt-get -qq autoremove
+killall -9 chef-client
+SCRIPT
 
 Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
 
@@ -16,30 +75,12 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
 
   config.vm.synced_folder ".", "/vagrant", disabled: true
   config.vm.synced_folder ".", "/home/vagrant/src/github.com/weaveworks/weave"
-  config.vm.provision :shell, :inline => "ln -sf /home/vagrant/src/github.com/weaveworks/weave /home/vagrant/"
 
-  config.vm.provision :shell, :inline => "sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 36A1D7869245C8950F966E92D8576A8BA88D21E9"
-  config.vm.provision :shell, :inline => "echo deb https://get.docker.io/ubuntu docker main > /etc/apt/sources.list.d/docker.list"
-
-  pkg_cmd = "export DEBIAN_FRONTEND=noninteractive; " \
-    "apt-get update -qq; " \
-    "apt-get install -qq --no-install-recommends #{pkgs}"
-
-  install_go_toolchain = "curl -s https://storage.googleapis.com/golang/go1.4.2.linux-amd64.tar.gz | tar xz -C /usr/local"
-
-  go_path = "/usr/local/go/bin"
-
-  config.vm.provision :shell, :inline => pkg_cmd
-  config.vm.provision :shell, :inline => install_go_toolchain
-  config.vm.provision :shell, :inline => "usermod -a -G docker vagrant"
-  config.vm.provision :shell, :inline => "echo export GOPATH=\"\${HOME\}\" >> ~vagrant/.profile", :privileged => false
-  config.vm.provision :shell, :inline => "echo export PATH=\"\${HOME}/bin:#{go_path}:\${PATH}\" >> ~vagrant/.profile", :privileged => false
-
-  config.vm.provision :shell, :inline => "chown -R vagrant:vagrant ~vagrant/src"
-  config.vm.provision :shell, :inline => "#{go_path}/go clean -i net; #{go_path}/go install -tags netgo std"
-
-  config.vm.provision :shell, :inline => "echo 'DOCKER_OPTS=\"-H unix:///var/run/docker.sock -H tcp://0.0.0.0:2375\"' >> /etc/default/docker"
-  config.vm.provision :shell, :inline => "service docker restart"
+  config.vm.provision :shell, :inline => $install_build_deps
+  config.vm.provision :shell, :inline => $install_go_toochain
+  config.vm.provision :shell, :inline => $tweak_user_env, :privileged => false
+  config.vm.provision :shell, :inline => $tweak_docker_daemon
+  config.vm.provision :shell, :inline => $cleanup
 
 end