diff --git a/prog/weaveutil/addrs.go b/prog/weaveutil/addrs.go index 068f37e5..ddd0de62 100644 --- a/prog/weaveutil/addrs.go +++ b/prog/weaveutil/addrs.go @@ -7,19 +7,19 @@ import ( ) func containerAddrs(args []string) error { - if len(args) < 2 { - cmdUsage("container-addrs", " [containerID ...]") + if len(args) < 1 { + cmdUsage("container-addrs", " [containerID ...]") } + bridgeName := args[0] - procPath := args[0] - bridgeName := args[1] + procPath := procDir() c, err := docker.NewVersionedClientFromEnv("1.18") if err != nil { return err } - for _, containerID := range args[2:] { + for _, containerID := range args[1:] { netDevs, err := getNetDevs(procPath, bridgeName, c, containerID) if err != nil { if _, ok := err.(*docker.NoSuchContainer); ok { diff --git a/prog/weaveutil/docker_tls_args.go b/prog/weaveutil/docker_tls_args.go index a61ab8ce..9f889657 100644 --- a/prog/weaveutil/docker_tls_args.go +++ b/prog/weaveutil/docker_tls_args.go @@ -7,7 +7,6 @@ import ( "bytes" "fmt" "io/ioutil" - "os" "path/filepath" "strconv" "strings" @@ -17,10 +16,7 @@ func dockerTLSArgs(args []string) error { if len(args) > 0 { cmdUsage("docker-tls-args", "") } - procRoot := os.Getenv("PROCFS") - if procRoot == "" { - procRoot = "/proc" - } + procRoot := procDir() dirEntries, err := ioutil.ReadDir(procRoot) if err != nil { return err diff --git a/prog/weaveutil/main.go b/prog/weaveutil/main.go index 1d737341..8522f824 100644 --- a/prog/weaveutil/main.go +++ b/prog/weaveutil/main.go @@ -60,3 +60,11 @@ func cmdUsage(cmd string, usage string) { fmt.Fprintf(os.Stderr, "usage: weaveutil %s %s\n", cmd, usage) os.Exit(1) } + +func procDir() string { + procDir := os.Getenv("PROCFS") + if procDir == "" { + procDir = "/proc" + } + return procDir +} diff --git a/weave b/weave index 4768a47a..25d732cd 100755 --- a/weave +++ b/weave @@ -1034,7 +1034,7 @@ with_container_addresses() { COMMAND=$1 shift 1 - util_op container-addrs $PROCFS $BRIDGE "$@" | while read CONTAINER_ID CONTAINER_MAC CONTAINER_IPS; do + util_op container-addrs $BRIDGE "$@" | while read CONTAINER_ID CONTAINER_MAC CONTAINER_IPS; do $COMMAND "$CONTAINER_ID" "$CONTAINER_MAC" "$CONTAINER_IPS" done }