From 5b6a892c38ec926d0c4c1b28debfc9a242f03989 Mon Sep 17 00:00:00 2001
From: Matthias Radestock <matthias.radestock@gmail.com>
Date: Fri, 24 Oct 2014 12:57:35 +0100
Subject: [PATCH] refactor: don't extract param to var and shift unless we have
 to

---
 weave | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/weave b/weave
index c5b460fa..5f987f0d 100755
--- a/weave
+++ b/weave
@@ -301,10 +301,9 @@ case "$COMMAND" in
         ;;
     start)
         [ $# -gt 1 ] || usage
-        IPADDR=$1
         create_bridge
         CONTAINER=$(docker start $2)
-        with_container_netns $CONTAINER attach $IPADDR $CONTAINER_IFNAME
+        with_container_netns $CONTAINER attach $1 $CONTAINER_IFNAME
         echo $CONTAINER
         ;;
     attach)
@@ -318,22 +317,18 @@ case "$COMMAND" in
         ;;
     expose)
         [ $# -gt 0 ] || usage
-        IPADDR=$1
-        shift 1
         create_bridge
-        if ! ip addr show dev $BRIDGE | grep -qF $IPADDR
+        if ! ip addr show dev $BRIDGE | grep -qF $1
         then
-            ip addr add dev $BRIDGE $IPADDR
+            ip addr add dev $BRIDGE $1
         fi
         ;;
     hide)
         [ $# -gt 0 ] || usage
-        IPADDR=$1
-        shift 1
         create_bridge
-        if ip addr show dev $BRIDGE | grep -qF $IPADDR
+        if ip addr show dev $BRIDGE | grep -qF $1
         then
-            ip addr del dev $BRIDGE $IPADDR
+            ip addr del dev $BRIDGE $1
         fi
         ;;
     stop)