From 926c85c6ba1e340b4c5add8b1d523f27dc149627 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Sun, 14 Jun 2015 15:48:08 +0100 Subject: [PATCH] more idiomatic 'boolean' in shell --- weave | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/weave b/weave index 1148d519..7c39bc04 100755 --- a/weave +++ b/weave @@ -650,7 +650,7 @@ dns_args() { DNS_ARG="--dns $DOCKER_BRIDGE_IP" DNS_SEARCH_ARG="--dns-search=." NAME_ARG="" - HOSTNAME_SPECIFIED=false + HOSTNAME_SPECIFIED= while [ $# -gt 0 ] ; do case "$1" in --dns-search=*) @@ -666,7 +666,7 @@ dns_args() { shift ;; -h|--hostname|--hostname=*) - HOSTNAME_SPECIFIED=true + HOSTNAME_SPECIFIED=1 shift ;; *) @@ -675,7 +675,7 @@ dns_args() { esac done DNS_ARGS="$DNS_ARG $DNS_SEARCH_ARG" - if [ -n "$NAME_ARG" -a "$HOSTNAME_SPECIFIED" = "false" ] ; then + if [ -n "$NAME_ARG" -a -z "$HOSTNAME_SPECIFIED" ] ; then DNS_ARGS="$DNS_ARGS --hostname=$NAME_ARG.$(dns_domain)" fi }