diff --git a/test/225_dns_subdomain_test.sh b/test/225_dns_subdomain_test.sh index a40f13a4..59a1cd46 100755 --- a/test/225_dns_subdomain_test.sh +++ b/test/225_dns_subdomain_test.sh @@ -13,9 +13,9 @@ start_suite "Resolve names in custom domain with subdomains" weave_on $HOST1 launch --log-level=debug --dns-domain $DOMAIN. -start_container_with_dns $HOST1 $C1/24 --name=c1 -h foo.$SUBDOMAIN1 -start_container_with_dns $HOST1 $C2/24 --name=c2 -h foo.$SUBDOMAIN2 -start_container_with_dns $HOST1 $C3/24 --name=c3 -h tre.$SUBDOMAIN1 --dns-search=$SUBDOMAIN2 +proxy_start_container_with_dns $HOST1 -e WEAVE_CIDR=$C1/24 --name=c1 -h foo.$SUBDOMAIN1 +proxy_start_container_with_dns $HOST1 -e WEAVE_CIDR=$C2/24 --name=c2 -h foo.$SUBDOMAIN2 +proxy_start_container_with_dns $HOST1 -e WEAVE_CIDR=$C3/24 --name=c3 -h tre.$SUBDOMAIN1 --dns-search=$SUBDOMAIN2 assert_dns_record $HOST1 c1 foo.$SUBDOMAIN2 $C2 assert_dns_a_record $HOST1 c3 foo $C2 foo.$SUBDOMAIN2 diff --git a/test/230_dns_unqualified_test.sh b/test/230_dns_unqualified_test.sh index 1c5e9291..802b9916 100755 --- a/test/230_dns_unqualified_test.sh +++ b/test/230_dns_unqualified_test.sh @@ -13,9 +13,9 @@ start_suite "Resolve unqualified names" weave_on $HOST1 launch -start_container $HOST1 $C1/24 --name=c1 -h $NAME -start_container_with_dns $HOST1 $C2/24 --name=c2 -h seetwo.$DOMAIN -start_container_with_dns $HOST1 $C3/24 --name=c3 --dns-search=$DOMAIN +proxy_start_container $HOST1 -e WEAVE_CIDR=$C1/24 --name=c1 -h $NAME +proxy_start_container_with_dns $HOST1 -e WEAVE_CIDR=$C2/24 --name=c2 -h seetwo.$DOMAIN +proxy_start_container_with_dns $HOST1 -e WEAVE_CIDR=$C3/24 --name=c3 --dns-search=$DOMAIN container=$(start_container_with_dns $HOST1 $C4/24) assert_dns_a_record $HOST1 c2 seeone $C1 $NAME diff --git a/test/280_with_or_without_dns_test.sh b/test/280_with_or_without_dns_test.sh index 7ba86452..f71b9271 100755 --- a/test/280_with_or_without_dns_test.sh +++ b/test/280_with_or_without_dns_test.sh @@ -7,14 +7,15 @@ TARGET=seetwo.weave.local TARGET_IP=10.2.0.78 STATIC=static.name STATIC_IP=10.9.9.9 +ATTACH_ARGS="--rewrite-hosts --add-host=$STATIC:$STATIC_IP" check_dns() { chk=$1 shift - container=$(docker_on $HOST1 run $(dns_args $HOST1 "$@") -dt $DNS_IMAGE /bin/sh) - weave_on $HOST1 attach $IP/24 "$@" --rewrite-hosts --add-host=$STATIC:$STATIC_IP $container + container=$(start_container_with_dns $HOST1 "$@" $IP/24) $chk $HOST1 $container $TARGET + # --add-host adds to /etc/hosts so should work even when DNS is off. assert_dns_record $HOST1 $container $STATIC $STATIC_IP rm_containers $HOST1 $container } @@ -22,10 +23,18 @@ check_dns() { start_suite "With or without DNS test" # Assert behaviour without weaveDNS running -weave_on $HOST1 launch +weave_on $HOST1 launch --no-dns start_container $HOST1 $TARGET_IP/24 --name c2 -h $TARGET +check_dns assert_no_dns_record --without-dns +check_dns assert_no_dns_record + +weave_on $HOST1 stop + +# Assert behaviour with weaveDNS +weave_on $HOST1 launch + check_dns assert_no_dns_record --without-dns check_dns assert_dns_record diff --git a/test/config.sh b/test/config.sh index 29958867..f0df952b 100644 --- a/test/config.sh +++ b/test/config.sh @@ -189,7 +189,7 @@ start_container_image() { fi is_cidr "$1" && { cidr=$1; shift; } container=$(docker_on $host run $weave_dns_args $name_args "$@" -dt $image /bin/sh) - if ! weave_on $host attach $cidr $container >/dev/null ; then + if ! weave_on $host attach $cidr $ATTACH_ARGS $container >/dev/null ; then docker_on $host rm -f $container return 1 fi