From a4062bd15ceb253eb57e802d8f97ab7a02d151cf Mon Sep 17 00:00:00 2001 From: Martynas Pumputis Date: Fri, 8 Apr 2016 18:49:06 +0100 Subject: [PATCH] Remove trailing dot from FQDN As it is described in #2140, the trailing dot might appear when starting a container via "weave run". --- test/270_use_name_as_hostname_test.sh | 3 ++- weave | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/270_use_name_as_hostname_test.sh b/test/270_use_name_as_hostname_test.sh index 4ef841b9..377bb5aa 100755 --- a/test/270_use_name_as_hostname_test.sh +++ b/test/270_use_name_as_hostname_test.sh @@ -8,7 +8,8 @@ HOSTNAME=$NAME-hostname.$DOMAIN # Docker inspect hostname + domainname of container $2 on host $1 docker_inspect_fqdn() { - docker_on $1 inspect --format='{{.Config.Hostname}}.{{.Config.Domainname}}' $2 + FQDN=$(docker_on $1 inspect --format='{{.Config.Hostname}}.{{.Config.Domainname}}' $2) + echo ${FQDN%.} } # Start container with args $2.. and assert fqdn of $1 diff --git a/weave b/weave index d6440f40..2513517e 100755 --- a/weave +++ b/weave @@ -1150,7 +1150,7 @@ etc_hosts_contents() { shift NAME=${FQDN%%.*} HOSTNAMES="$NAME" - [ "$NAME" = "$FQDN" -o "$NAME." = "$FQDN" ] || HOSTNAMES="$FQDN $HOSTNAMES" + [ "$NAME" = "$FQDN" -o "$NAME." = "$FQDN" ] || HOSTNAMES="${FQDN%.} $HOSTNAMES" echo "# created by Weave - BEGIN" echo "# container hostname"