From 79f77f94f4a16de8d6b29a65270e15247236a5f5 Mon Sep 17 00:00:00 2001 From: Martynas Pumputis Date: Fri, 21 Sep 2018 13:18:46 +0300 Subject: [PATCH] ipam: Do not deref nil in GET /ipinfo/tracker if tracker doesn't exist In some cases, we do not create any IPAM tracker, which leads to a panic when GET'ing /ipinfo/tracker. --- ipam/http.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ipam/http.go b/ipam/http.go index 187a6b4e..87cd8be7 100644 --- a/ipam/http.go +++ b/ipam/http.go @@ -199,6 +199,10 @@ func (alloc *Allocator) HandleHTTP(router *mux.Router, defaultSubnet address.CID }) router.Methods("GET").Path("/ipinfo/tracker").HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - fmt.Fprintf(w, alloc.tracker.String()) + tracker := "" + if alloc.tracker != nil { + tracker = alloc.tracker.String() + } + fmt.Fprintf(w, tracker) }) }