From b3536859d29bc776bf7a925fc235016e62e3634a Mon Sep 17 00:00:00 2001 From: Michael Bridgen Date: Tue, 30 Sep 2014 14:39:46 +0100 Subject: [PATCH 1/2] Included where to put the repo in the instructions Just in case, like me, the person following the instructions does not know go all that well. You can make it work without doing things exactly this way, but you may not get what you expect (because it might, for example, fetch the weave code from github instead of using the directory you're in). --- README.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index a8c1fb52..ce1c8d98 100644 --- a/README.md +++ b/README.md @@ -506,8 +506,16 @@ and the 'run' command like this: (NB. This is only necessary if you want to work on weave. Also, these instructions have only been tested on Ubuntu.) -To build weave you need `libpcap-dev` and `docker` installed. And -`go`. +To build weave you need `libpcap-dev` and `docker` installed. And `go` +(and `git` and `hg` to fetch dependencies). + +The package name is `github.com/zettio/weave`, so assuming `$GOPATH` +is set: + + $ cd $GOPATH + $ mkdir -p src/github.com/zettio + $ cd src/github.com/zettio + $ git clone https://github.com/zettio/weave Then simply run From 68c6ba720309c3bcd1ef1b15f616ec49a9e9792f Mon Sep 17 00:00:00 2001 From: Michael Bridgen Date: Tue, 30 Sep 2014 14:51:16 +0100 Subject: [PATCH 2/2] Simplified cloning instructions The package name and directory to clone into are almost the same. (The previous revision also neglected to tell you to cd into the repo dir) --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index ce1c8d98..44ccce70 100644 --- a/README.md +++ b/README.md @@ -513,9 +513,9 @@ The package name is `github.com/zettio/weave`, so assuming `$GOPATH` is set: $ cd $GOPATH - $ mkdir -p src/github.com/zettio - $ cd src/github.com/zettio - $ git clone https://github.com/zettio/weave + $ WEAVE=github.com/zettio/weave + $ git clone https://$WEAVE src/$WEAVE + $ cd src/$WEAVE Then simply run