From c59c86c660cabe5eeaae3008e1bac58680af2117 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Thu, 20 Apr 2017 10:43:16 +0000 Subject: [PATCH] Only publish "latest" tag on v2 plugin if explicitly told to For V2 plugin, "latest" means "latest stable release", to make instructions simple for end-users. So we don't want to overwrite "latest" with a random build by accident. --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 57a679bb..8374dc80 100644 --- a/Makefile +++ b/Makefile @@ -311,7 +311,8 @@ tools/.git $(MANIFEST_TOOL_DIR)/.git: # Push plugin plugin_publish: $(PLUGIN_UPTODATE) $(SUDO) DOCKER_HOST=$(DOCKER_HOST) docker plugin push $(PLUGIN_IMAGE):$(WEAVE_VERSION) -ifneq ($(UPDATE_LATEST),false) +# "latest" means "stable release" here, so only push that if explicitly told to +ifeq ($(UPDATE_LATEST),true) $(SUDO) DOCKER_HOST=$(DOCKER_HOST) docker plugin push $(PLUGIN_IMAGE):latest endif