From ac4246e1f55c269d8734bc3ab617b3c16746dd0f Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Tue, 6 Sep 2016 12:05:51 +0100 Subject: [PATCH] Pass in default subnet when creating 'weave' plugin network. New behaviour in Docker 1.12 means it disregards a plugin-supplied address pool that overlaps an existing route, which causes a hang as noted in #2469. When we pass in the subnet, Docker believes we really do want that address range and avoids the hang. --- prog/weaveutil/plugin_network.go | 12 ++++++++---- weave | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/prog/weaveutil/plugin_network.go b/prog/weaveutil/plugin_network.go index 9ff52314..33c3a79a 100644 --- a/prog/weaveutil/plugin_network.go +++ b/prog/weaveutil/plugin_network.go @@ -10,11 +10,12 @@ import ( ) func createPluginNetwork(args []string) error { - if len(args) != 2 { - cmdUsage("create-plugin-network", " ") + if len(args) != 3 { + cmdUsage("create-plugin-network", " ") } networkName := args[0] driverName := args[1] + subnet := args[2] d, err := newDockerClient() if err != nil { return err @@ -24,8 +25,11 @@ func createPluginNetwork(args []string) error { Name: networkName, CheckDuplicate: true, Driver: driverName, - IPAM: docker.IPAMOptions{Driver: driverName}, - Options: map[string]interface{}{plugin.MulticastOption: "true"}, + IPAM: docker.IPAMOptions{ + Driver: driverName, + Config: []docker.IPAMConfig{{Subnet: subnet}}, + }, + Options: map[string]interface{}{plugin.MulticastOption: "true"}, }) if err != docker.ErrNetworkAlreadyExists && err != nil { // Despite appearances to the contrary, CreateNetwork does diff --git a/weave b/weave index c23570d2..97d6a25a 100755 --- a/weave +++ b/weave @@ -1782,7 +1782,8 @@ launch_plugin_if_not_running() { return 1 fi wait_for_status $PLUGIN_CONTAINER_NAME http_call_unix $PLUGIN_CONTAINER_NAME status.sock - util_op create-plugin-network weave weavemesh + WEAVE_IPAM_SUBNET=$(call_weave GET /ipinfo/defaultsubnet) + util_op create-plugin-network weave weavemesh $WEAVE_IPAM_SUBNET } plugin_disabled() {