From c7701a20b5f7e03a6a17b0876eb6ab30ca6f13fa Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Mon, 19 Jan 2015 17:01:20 +0000 Subject: [PATCH] refactor: if->switch --- router/connection.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/router/connection.go b/router/connection.go index e004d65e..84004e16 100644 --- a/router/connection.go +++ b/router/connection.go @@ -434,16 +434,16 @@ func (conn *LocalConnection) handshake(enc *gob.Encoder, dec *gob.Decoder, accep toPeer := NewPeer(name, uid, 0) toPeer = conn.Router.Peers.FetchWithDefault(toPeer) - if toPeer == nil { + switch toPeer { + case nil: return fmt.Errorf("Connection appears to be with different version of a peer we already know of") - } else if toPeer == conn.local { - // have to do assigment here to ensure Shutdown releases ref count - conn.remote = toPeer + case conn.local: + conn.remote = toPeer // have to do assigment here to ensure Shutdown releases ref count return fmt.Errorf("Cannot connect to ourself") + default: + conn.remote = toPeer + return nil } - conn.remote = toPeer - - return nil } func checkHandshakeStringField(fieldName string, expectedValue string, handshake map[string]string) (string, error) {