From d01c26e618cf5afb8c725b243c27c693ea421ba7 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Tue, 17 Nov 2015 09:27:49 +0000 Subject: [PATCH] cosmetic: remove outdated comment The deadlock described for SendProtocolMsg (if it was going via the actor) cannot occur since all sending of broadcasts and gossip by LocalPeer is mediated by GossipSenders, the interaction with which is non-blocking. --- mesh/connection.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mesh/connection.go b/mesh/connection.go index d6ddf3a8..7e9a671a 100644 --- a/mesh/connection.go +++ b/mesh/connection.go @@ -116,11 +116,6 @@ func (conn *LocalConnection) Established() bool { return conn.established } -// Send directly, not via the Actor. If it goes via the Actor we can -// get a deadlock where LocalConnection is blocked talking to -// LocalPeer and LocalPeer is blocked trying send a ProtocolMsg via -// LocalConnection, and the channels are full in both directions so -// nothing can proceed. func (conn *LocalConnection) SendProtocolMsg(m ProtocolMsg) { if err := conn.sendProtocolMsg(m); err != nil { conn.Shutdown(err)