Commit Graph
17 Commits
Author SHA1 Message Date
Matthias Radestock 1c5d720db4 simplify some more 2014-12-24 13:38:17 +00:00
Matthias Radestock fecbf220cc simplify 2014-12-24 13:35:51 +00:00
Matthias Radestock 9cd652ef0b refactor: introduce small helper 2014-12-24 13:29:13 +00:00
Matthias Radestock 108e468ada Merge branch 'master' into eliminate_heartbeater
Conflicts:
	router/connection.go
2014-12-24 10:48:39 +00:00
Matthias Radestock 5ccc753367 kill stale connections
The weave protocol already effectively performs heartbeating -
FetchAll is performed at regular intervals. Hence we can detect stale
connections by the lack of receiving any data for approximately that
interval (we use x2).

We use the same interval to set a time limit on the handshake too, and
any subsequent interactions prior to the connection being fully
established.

Fixes #272.
2014-12-24 10:33:37 +00:00
Matthias Radestock 3c50909a49 nodelay is the default, according to the docs 2014-12-24 09:09:00 +00:00
Matthias Radestock e850127ed4 git rid of heartbeater goroutine
...by moving the logic into the connection actor goroutine.

The heartbeater goroutine was doing a lot more than just heartbeating;
namely it also had tickers for triggering a ProtocolFetchAll and
initiating a fragmentation test. Furhermore, ensureHeartbeats also
spawned the forwarders.

So this was quite a mix of functionality, and, furthermore, most of it
related quite closely to the connection actor. So moving the
functionality into that simplifies the code.

In the process we also fix #294.
2014-12-23 22:01:03 +00:00
Matthias Radestock 9ecef5e458 refactor 2014-12-12 14:39:14 +00:00
rade 8dfdeb3eff Merge pull request #271 from bboreham/258_rebuild_routes
Move call to Topology.RebuildRoutes

Closes #258
2014-12-12 14:34:52 +00:00
Bryan Boreham 4c88eb48c0 Move call to Topology.RebuildRoutes
It doesn't belong in handleBroadcastTCP(), so moved it up
to the two places that cause that function to be called.
2014-12-11 00:50:45 +00:00
Bryan Boreham 3a684ba3a9 Fixed typo in error message 2014-12-05 17:44:41 +00:00
Bryan Boreham 997e6ed2b9 squash two ifs together 2014-11-14 14:28:45 +00:00
Bryan Boreham 57aecb868f Add check during initial handshake whether we already have an established connection to this peer 2014-11-14 14:02:33 +00:00
Bryan Boreham e8ec9e84ce clarify messages used on connection errors 2014-10-15 19:34:43 +01:00
Matthias Radestock 4ffd15206b remove outdated comment 2014-10-15 15:41:29 +01:00
Matthias Radestock a587fef9c4 fix package name following move 2014-10-15 15:20:49 +01:00
Matthias Radestock e2fd1fda31 move router code 2014-10-15 15:07:42 +01:00