Introduce an intermediary - GossipSender - between GossipChannel and Connection. This accumulates gossip data (now represented by the new GossipData interface) from the former until it can be passed onto the latter, allowing the former to proceed when the latter may be blocked on i/o. This 1) prevents deadlocks that arise from cycles in the communication topology 2) improves performance by allowing GossipChannel and its calling code to proceed when connection i/o is blocked 3) improves performance by accumulating GossipData - the accumulated data often is considerably more compact than the sum of all the accumulated bits, and it is transmitted in a single communication event. In order to support accumulation, the GossipData interface has a Merge method. Furthermore, encoding is deferred until the data can actually be sent, since accumulation would be hard/impossible to encoded data. This required changes on some interfaces, most notably Gossiper. The implementation of GossipData for topology gossip is TopologyGossipData. It carries a reference to Peers and a set of PeerNames, indexing into Peers and referencing the Peer entries which have changed. Previously updates were represented as a list of Peer entries. The indirection via PeerNames allows Encode to omit entries which have been removed. The change in representation required changes to the signature of some methods on Peers. Note that all the above only applies to the "periodic gossip" portion of the Gossiper API, which topology gossip in fact uses for *all* gossip. GossipUnicast and GossipBroadcast are unchanged, but could conceivably receive the same treatment in the future. Fixes #445.
249 lines
6.6 KiB
Go
249 lines
6.6 KiB
Go
package router
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/gob"
|
|
"fmt"
|
|
"log"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
const GossipInterval = 30 * time.Second
|
|
|
|
type GossipData interface {
|
|
Encode() []byte
|
|
Merge(GossipData)
|
|
}
|
|
|
|
type Gossip interface {
|
|
// specific message from one peer to another
|
|
// intermediate peers relay it using unicast topology.
|
|
GossipUnicast(dstPeerName PeerName, buf []byte) error
|
|
// send a message to every peer, relayed using broadcast topology.
|
|
GossipBroadcast(buf []byte) error
|
|
}
|
|
|
|
type Gossiper interface {
|
|
OnGossipUnicast(sender PeerName, msg []byte) error
|
|
OnGossipBroadcast(msg []byte) error
|
|
// return state of everything we know; gets called periodically
|
|
Gossip() GossipData
|
|
// merge in state and return "everything new I've just learnt",
|
|
// or nil if nothing in the received message was new
|
|
OnGossip(buf []byte) (GossipData, error)
|
|
}
|
|
|
|
// Accumulates GossipData that needs to be sent to one destination,
|
|
// and sends it when possible.
|
|
type GossipSender struct {
|
|
channel *GossipChannel
|
|
sender ProtocolSender
|
|
cell chan GossipData
|
|
}
|
|
|
|
func NewGossipSender(c *GossipChannel, ps ProtocolSender) *GossipSender {
|
|
return &GossipSender{channel: c, sender: ps}
|
|
}
|
|
|
|
func (sender *GossipSender) Start() {
|
|
sender.cell = make(chan GossipData, 1)
|
|
go sender.run()
|
|
}
|
|
|
|
func (sender *GossipSender) run() {
|
|
for {
|
|
if pending := <-sender.cell; pending == nil { // receive zero value when chan is closed
|
|
break
|
|
} else {
|
|
sender.sendPending(pending)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (sender *GossipSender) sendPending(pending GossipData) {
|
|
sender.sender.SendProtocolMsg(sender.channel.gossipMsg(pending.Encode()))
|
|
}
|
|
|
|
func (sender *GossipSender) Send(data GossipData) {
|
|
// NB: this must not be invoked concurrently
|
|
select {
|
|
case pending := <-sender.cell:
|
|
pending.Merge(data)
|
|
sender.cell <- pending
|
|
default:
|
|
sender.cell <- data
|
|
}
|
|
}
|
|
|
|
func (sender *GossipSender) Stop() {
|
|
close(sender.cell)
|
|
}
|
|
|
|
type senderMap map[Connection]*GossipSender
|
|
|
|
type GossipChannel struct {
|
|
sync.Mutex
|
|
ourself *LocalPeer
|
|
name string
|
|
hash uint32
|
|
gossiper Gossiper
|
|
senders senderMap
|
|
}
|
|
|
|
func (router *Router) NewGossip(channelName string, g Gossiper) Gossip {
|
|
channelHash := hash(channelName)
|
|
channel := &GossipChannel{
|
|
ourself: router.Ourself,
|
|
name: channelName,
|
|
hash: channelHash,
|
|
gossiper: g,
|
|
senders: make(senderMap)}
|
|
router.GossipChannels[channelHash] = channel
|
|
return channel
|
|
}
|
|
|
|
func (router *Router) SendAllGossip() {
|
|
for _, channel := range router.GossipChannels {
|
|
channel.SendGossip(channel.gossiper.Gossip())
|
|
}
|
|
}
|
|
|
|
func (router *Router) SendAllGossipDown(conn Connection) {
|
|
for _, channel := range router.GossipChannels {
|
|
channel.SendGossipDown(conn, channel.gossiper.Gossip())
|
|
}
|
|
}
|
|
|
|
func (router *Router) handleGossip(payload []byte, onok func(*GossipChannel, PeerName, []byte, *gob.Decoder) error) error {
|
|
decoder := gob.NewDecoder(bytes.NewReader(payload))
|
|
var channelHash uint32
|
|
if err := decoder.Decode(&channelHash); err != nil {
|
|
return err
|
|
}
|
|
channel, found := router.GossipChannels[channelHash]
|
|
if !found {
|
|
return fmt.Errorf("[gossip] received unknown channel with hash %v", channelHash)
|
|
}
|
|
var srcName PeerName
|
|
if err := decoder.Decode(&srcName); err != nil {
|
|
return err
|
|
}
|
|
if err := onok(channel, srcName, payload, decoder); err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func deliverGossipUnicast(channel *GossipChannel, srcName PeerName, origPayload []byte, dec *gob.Decoder) error {
|
|
var destName PeerName
|
|
if err := dec.Decode(&destName); err != nil {
|
|
return err
|
|
}
|
|
if channel.ourself.Name == destName {
|
|
var payload []byte
|
|
if err := dec.Decode(&payload); err != nil {
|
|
return err
|
|
}
|
|
return channel.gossiper.OnGossipUnicast(srcName, payload)
|
|
} else {
|
|
return channel.relayGossipUnicast(destName, origPayload)
|
|
}
|
|
}
|
|
|
|
func deliverGossipBroadcast(channel *GossipChannel, srcName PeerName, origPayload []byte, dec *gob.Decoder) error {
|
|
var payload []byte
|
|
if err := dec.Decode(&payload); err != nil {
|
|
return err
|
|
}
|
|
if err := channel.gossiper.OnGossipBroadcast(payload); err != nil {
|
|
return err
|
|
}
|
|
return channel.relayGossipBroadcast(srcName, origPayload)
|
|
}
|
|
|
|
func deliverGossip(channel *GossipChannel, srcName PeerName, _ []byte, dec *gob.Decoder) error {
|
|
var payload []byte
|
|
if err := dec.Decode(&payload); err != nil {
|
|
return err
|
|
}
|
|
if data, err := channel.gossiper.OnGossip(payload); err != nil {
|
|
return err
|
|
} else if data != nil {
|
|
channel.SendGossip(data)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *GossipChannel) SendGossip(data GossipData) {
|
|
connections := c.ourself.Connections() // do this outside the lock so they don't nest
|
|
retainedSenders := make(senderMap)
|
|
c.Lock()
|
|
defer c.Unlock()
|
|
for _, conn := range connections {
|
|
c.sendGossipDown(conn, data)
|
|
retainedSenders[conn] = c.senders[conn]
|
|
delete(c.senders, conn)
|
|
}
|
|
// stop any senders for connections that are gone
|
|
for _, sender := range c.senders {
|
|
sender.Stop()
|
|
}
|
|
c.senders = retainedSenders
|
|
}
|
|
|
|
func (c *GossipChannel) SendGossipDown(conn Connection, data GossipData) {
|
|
c.Lock()
|
|
c.sendGossipDown(conn, data)
|
|
c.Unlock()
|
|
}
|
|
|
|
func (c *GossipChannel) sendGossipDown(conn Connection, data GossipData) {
|
|
sender, found := c.senders[conn]
|
|
if !found {
|
|
sender = NewGossipSender(c, conn.(ProtocolSender))
|
|
c.senders[conn] = sender
|
|
sender.Start()
|
|
}
|
|
sender.Send(data)
|
|
}
|
|
|
|
func (c *GossipChannel) gossipMsg(buf []byte) ProtocolMsg {
|
|
return ProtocolMsg{ProtocolGossip, GobEncode(c.hash, c.ourself.Name, buf)}
|
|
}
|
|
|
|
func (c *GossipChannel) GossipUnicast(dstPeerName PeerName, buf []byte) error {
|
|
return c.relayGossipUnicast(dstPeerName, GobEncode(c.hash, c.ourself.Name, dstPeerName, buf))
|
|
}
|
|
|
|
func (c *GossipChannel) GossipBroadcast(buf []byte) error {
|
|
return c.relayGossipBroadcast(c.ourself.Name, GobEncode(c.hash, c.ourself.Name, buf))
|
|
}
|
|
|
|
func (c *GossipChannel) relayGossipUnicast(dstPeerName PeerName, msg []byte) error {
|
|
if relayPeerName, found := c.ourself.Router.Routes.Unicast(dstPeerName); !found {
|
|
c.log("unknown relay destination:", dstPeerName)
|
|
} else if conn, found := c.ourself.ConnectionTo(relayPeerName); !found {
|
|
c.log("unable to find connection to relay peer", relayPeerName)
|
|
} else {
|
|
conn.(ProtocolSender).SendProtocolMsg(ProtocolMsg{ProtocolGossipUnicast, msg})
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *GossipChannel) relayGossipBroadcast(srcName PeerName, msg []byte) error {
|
|
if srcPeer, found := c.ourself.Router.Peers.Fetch(srcName); !found {
|
|
c.log("unable to relay broadcast from unknown peer", srcName)
|
|
} else {
|
|
protocolMsg := ProtocolMsg{ProtocolGossipBroadcast, msg}
|
|
for _, conn := range c.ourself.NextBroadcastHops(srcPeer) {
|
|
conn.SendProtocolMsg(protocolMsg)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (c *GossipChannel) log(args ...interface{}) {
|
|
log.Println(append(append([]interface{}{}, "[gossip "+c.name+"]:"), args...)...)
|
|
}
|