Matthias Radestock e639007b62 eliminate AddConnection/RemoveConnection race ...

We were invoking AddConnection in a separate goroutine, and this could
result in RemoveConnection getting invoked first, resulting in bogus
entries in our connection map, which would effectively prevent
connectivity to the other peer until the stale entry got removed
through a lost tie break. And if, per chance, the remote end ran into
exactly the same race condition, then connectivity between that peer
and ourself was broken permanently.

Hitting this race condition required a combination of a) no UDP
heartbeat being received for HeartbeatTimeout(30s) - this causes the
actorLoop to terminate and RemoveConnection to be invoked, and b) the
AddConnection invocation getting delayed for at least that long.

2015-04-09 06:34:35 +01:00

..

connection_maker.go

refactor: make Peer.Connections() return a set instead of a slice

2015-04-06 13:57:13 +01:00

connection.go

eliminate AddConnection/RemoveConnection race

2015-04-09 06:34:35 +01:00

consts.go

cosmetic: linting

2015-03-27 00:43:26 +00:00

crypto.go

refactor: rename

2015-03-28 19:52:10 +00:00

ethernet_decoder.go

Remove some layers of indirection around FrameTooBigError handling

2015-03-05 15:13:30 +00:00

forwarder.go

prevent PMTUVerfied handling from blocking

2015-03-29 14:04:28 +01:00

gossip_test.go

cosmetic: move some test helpers from test code into main code

2015-04-04 20:02:22 +01:00

gossip.go

switch to gossip broadcast for topology updates

2015-04-06 14:17:23 +01:00

handshake.go

refactor: extract helper

2015-03-27 12:38:06 +00:00

json.go

refactor: make Peer.Connections() return a set instead of a slice

2015-04-06 13:57:13 +01:00

local_peer.go

switch to gossip broadcast for topology updates

2015-04-06 14:17:23 +01:00

mac_cache.go

include peer nickname in display output whenever possible

2015-03-27 05:25:28 +00:00

mocks_test.go

tired of typing "struct{}{}"

2015-04-06 11:53:51 +01:00

pcap.go

fix package name following move

2014-10-15 15:20:49 +01:00

peer_name_hash.go

fix package name following move

2014-10-15 15:20:49 +01:00

peer_name_mac.go

fix package name following move

2014-10-15 15:20:49 +01:00

peer.go

refactor: make Peer.Connections() return a set instead of a slice

2015-04-06 13:57:13 +01:00

peers_test.go

cosmetic: linting

2015-03-27 00:43:26 +00:00

peers.go

add "representation of received update" to return of Peers.ApplyUpdate

2015-04-06 14:17:23 +01:00

protocol.go

switch to gossip broadcast for topology updates

2015-04-06 14:17:23 +01:00

router.go

switch to gossip broadcast for topology updates

2015-04-06 14:17:23 +01:00

routes.go

optimise broadcast route calculation

2015-04-08 21:54:45 +01:00

udp_sender.go

cosmetic: move a bunch of error types to where they belong

2015-01-20 21:01:50 +00:00

utils.go

tired of typing "struct{}{}"

2015-04-06 11:53:51 +01:00