fix: drop support for named pipes on Windows (#962)
Seems that folk are having issues with uploading 0-byte files from Windows agents. This effectively removes the support for Windows for uploading from named files that, due to `isFIFO` returning `false` on Windows for named pipes created using MSYS2's `mkfifo` command, resorted to checking if the file size is 0 - a common trait of named pipes. See https://github.com/actions/upload-artifact/issues/281
This commit is contained in:
1 parent
455aabdd18
commit
9d6767c399
3 files changed
+9
-7
No files matched your search
@@ -18,8 +18,10 @@ if [ ! -f "$path" ]; then
|
|||||||
exit 1
|
exit 1
|
||||||
fi
|
fi
|
||||||
|
|
||||||
actualContent=$(cat $path)
|
actualContent=$(cat "$path")
|
||||||
if [ "$actualContent" != "$expectedContent" ];then
|
if [ "$expectedContent" == "_EMPTY_" ] && [ ! -s "$path" ]; then
|
||||||
|
exit 0
|
||||||
|
elif [ "$actualContent" != "$expectedContent" ]; then
|
||||||
echo "File contents are not correct, expected $expectedContent, received $actualContent"
|
echo "File contents are not correct, expected $expectedContent, received $actualContent"
|
||||||
exit 1
|
exit 1
|
||||||
fi
|
fi
|
||||||
@@ -181,7 +181,10 @@ describe('Upload Tests', () => {
|
|||||||
function hasMkfifo(): boolean {
|
function hasMkfifo(): boolean {
|
||||||
try {
|
try {
|
||||||
// make sure we drain the stdout
|
// make sure we drain the stdout
|
||||||
return execSync('which mkfifo').toString().length > 0
|
return (
|
||||||
|
process.platform !== 'win32' &&
|
||||||
|
execSync('which mkfifo').toString().length > 0
|
||||||
|
)
|
||||||
} catch (e) {
|
} catch (e) {
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -221,10 +221,7 @@ export class UploadHttpClient {
|
|||||||
): Promise<UploadFileResult> {
|
): Promise<UploadFileResult> {
|
||||||
const fileStat: fs.Stats = await stat(parameters.file)
|
const fileStat: fs.Stats = await stat(parameters.file)
|
||||||
const totalFileSize = fileStat.size
|
const totalFileSize = fileStat.size
|
||||||
// on Windows with mkfifo from MSYS2 stats.isFIFO returns false, so we check if running on Windows node and
|
const isFIFO = fileStat.isFIFO()
|
||||||
// if the file has size of 0 to compensate
|
|
||||||
const isFIFO =
|
|
||||||
fileStat.isFIFO() || (process.platform === 'win32' && totalFileSize === 0)
|
|
||||||
let offset = 0
|
let offset = 0
|
||||||
let isUploadSuccessful = true
|
let isUploadSuccessful = true
|
||||||
let failedChunkSizes = 0
|
let failedChunkSizes = 0
|
||||||
|
|||||||
Reference in new issue
Block a user