Commit Graph
56 Commits
Author SHA1 Message Date
Ichinose Shogo f132cd5a9f artifact: @types/tmp should be devDependencies (#860) 2021-11-29 17:22:33 -05:00
Zoran Regvart b34bb89807 Support upload from named pipes (#748)
Named pipes report file size as 0, which leads to reading the whole
content into memory (0 is less than 64K). This adds additional check to
make sure that the passed in path is not a named pipe, and in that case
opts for the create-temp-file-to-gzip code path.

When running on GitHub Actions infrastructure on `windows` node, named
pipes can be created using `mkfifo` from MSYS2. In that case `fs.Stats`s
`isFIFO()` returns `false`, and not `true` as expected. This case is
detected by `process.platform` being `win32` and the passed file having
length of 0.

As a side note, when MSYS2's `mkfifo` is run, a pipe file is created:

```
prw-rw-rw- 1 User None  0 Mar 31 12:58 pipe
```

If `fs.stat` is invoked at this point `ENOENT` error will be thrown. As
soon as the pipe is written to, this pipe file is replaced by two same-
named files:

```
-rw-r--r-- 1 User None  0 Mar 31 13:00 pipe
-rw-r--r-- 1 User None  0 Mar 31 13:00 pipe
```

And at this point `fs.stat` `isFIFO()` returns `false`. Even though the
file acts as a named pipe.
2021-11-29 17:19:02 -05:00
Brian Cristante 88cfcccd96 Bump artifact package version to v0.5.2 (#845)
* bump version in package*.json

* changelog
2021-06-16 09:37:06 -04:00
Brian Cristante 77d96ef7df Retry artifact uploads on HTTP 500 (#833)
* Retry on 500

* bump package version

* fix tests

* Remove spurious change

* fix another test

* Roll back package version
2021-06-04 17:09:30 -04:00
Thomas Boop ef0fa675fa Re-enable the audit tools step and update dependencies (#815)
* update package versions

* run audit

* fix eslint config

* linter updates

* re-enable audit

* update timeouts test

* pass done into callback

* fix format
2021-05-21 09:19:40 -04:00
Konrad Pabjan cb22c5e7ce Bump artifact package version (#761) 2021-04-06 13:49:15 -04:00
Konrad Pabjan 2259e57a71 @actions/artifact 0.5.1 release (#760)
* Bump @actions/http-client to latest for artifact package

* Remove typescript libs to fix failing imports
2021-04-06 12:44:56 -04:00
Konrad Pabjan cf1d64fd9e Retry all http calls for artifact upload and download (#675)
* Retry all http calls for artifact upload and download

* Extra debug information

* Fix lint

* Always read response body

* PR Feedback

* Change error message if patch call fails

* Add exponential backoff when retrying

* Rework tests and add diagnostic info if exception thrown

* Fix lint

* fix lint error for real this time

* PR cleanup

* 0.5.0 @actions/artifact release

* Display diagnostic info if non-retryable code is hit
2020-12-18 21:40:50 +01:00
Konrad Pabjan d7c866b0f5 actions/artifact 0.4.2 release (#673)
* actions/artifact 0.4.2

* Update releases note
2020-12-11 17:43:12 +01:00
Chris Sidi 3198814def Merge pull request #661 from yacaovsnc/main
Retry artifact download when response stream is truncated (continued)
2020-12-04 13:10:40 -05:00
Yang CaoandChris Sidi 6f33e4c7b0 Close destination steam before reject
Co-authored-by: Chris Sidi <hashtagchris@github.com>
2020-12-04 11:03:17 -05:00
Yang Cao 2c4f1a3166 style change, refactor arg sequence 2020-12-04 09:41:00 -05:00
Yang Cao 2b5da11156 pipeResponseToFile already throws when reading truncated stream 2020-12-04 09:19:58 -05:00
Yang Cao 760a39afb9 Try close stream before unlink 2020-12-03 13:34:59 -05:00
Yang Cao bd9c0f996d Always print skip validation log 2020-12-03 13:09:43 -05:00
Yang Cao 1e10fa415c Add some debugging statements 2020-12-03 12:40:37 -05:00
Yang Cao 09e68f92cd More styling fix 2020-12-03 10:57:04 -05:00
Yang Cao 8f05cccf8e Fix styling 2020-12-03 10:33:10 -05:00
Yang Cao 9d3d4bec1b Adding retry when we received 200
If we received 200, we will attempt to download the stream. If the
stream is gzipped, gzip should throw an error when trying to decompress
the stream; or if the stream is truncated, the received bytes should be
different from the value set in content-length header.
2020-12-03 10:15:12 -05:00
Chris Sidi 61e11bd168 More error handling 2020-12-03 10:12:44 -05:00
Chris Sidi d26929d028 Retry artifact download when response stream is truncated 2020-12-03 10:12:44 -05:00
Chris Sidi 0a0169da7d Remove spyon, use readable stream to test pipeResponseToFile (#651)
* Remove spyon, use readable stream to test pipeResponseToFile

* Check file contents
2020-11-30 12:12:12 -05:00
Thomas Boop 89260944d9 Update @actions/core in remaining toolkit packages (#636)
* Update to latest @actions/core version

* Bump release notes for new versions

* Add correct pr #
2020-11-13 16:51:15 -05:00
Thomas Boop e67e3164d5 swap to file commands (#587)
* swap to file commands

* swap to require
2020-09-30 15:46:54 +02:00
Yang Cao 53a6f99290 Release preparation of artifact 0.4.0 (#578) 2020-09-18 19:06:53 +02:00
Yang CaoandKonrad Pabjan da436eaab9 Add an option to specify retention days for artifacts (#575)
* Add an option to specify retention days for artifacts

* Validate against settings exposed as env var to give early feedback

* Fix lint

* Add tests and addressing feedback

* Update packages/artifact/__tests__/upload.test.ts

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>

* Update packages/artifact/README.md

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>

* Update packages/artifact/src/internal/utils.ts

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>

* Update packages/artifact/__tests__/util.test.ts

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>

Co-authored-by: Konrad Pabjan <konradpabjan@github.com>
2020-09-18 11:30:00 -04:00
Thomas Boop 5d7c069a8e Add License.md to all npm packages (#548)
* Add License.md to all npm packages
2020-08-25 16:26:50 -04:00
Ross Brodbeck c8fa648f49 zeit renamed to vercel 2020-08-21 07:32:09 -04:00
Konrad Pabjan a0e6867306 @actions/artifact 0.3.5 2020-08-04 17:11:50 +02:00
Konrad Pabjan 975f43d6c7 Retry on 413 (#540) 2020-08-04 16:57:38 +02:00
Konrad Pabjan 9772449825 @actions/artifact 0.3.3 update 2020-07-30 17:30:41 +02:00
Konrad Pabjan e8b9b29050 Better Artifact Telemetry + Increase Upload chunk size (#535)
* Differentiate user-agents for better internal telemetry

* Bump chunk size from 4 to 8 MB

* Update User-Agent Strings
2020-07-30 17:23:28 +02:00
Thomas Boop fa8e43d045 Set main as the default branch (#527)
* set main as the default branch

* revert change to tool-cache default branch

* use versions where applicable
2020-07-21 11:33:05 -04:00
Thomas Boop 6fd70de397 Pipe audit results to a json file so lerna does not overflow (#515)
* Pipe audit results to a json file so lerna does not overflow

* reorder flags and args
2020-07-14 16:05:53 -04:00
Thomas Boop 96cbbc8b77 Explicitly exclude DS store files (#492) 2020-06-04 15:14:19 -04:00
Aiqiao Yan 623465dc88 Merge pull request #448 from actions/users/aiyan/cache-package
Initial commit to create @actions/cache package
2020-05-15 13:41:32 -04:00
Konrad Pabjan f8a5273a3b @actions/artifact 0.3.2 2020-05-15 18:34:09 +02:00
Aiqiao Yan 18218152a5 React to feedback 2020-05-15 12:26:42 -04:00
Konrad Pabjan 65a1e4334c Correctly reset chunk during artifact upload on retry (#458)
* Correctly reset chunk during artifact upload on retry

* Update workflow

* Implementation details around the passthrough stream
2020-05-14 22:18:21 +02:00
Konrad PabjanandJosh Gross 6a22ed8a90 artifact header cleanup (#441)
* Update NPM packages for @actions/artifact

* Clarifications around headers

* Revert NPM updates

* Apply suggestions from code review

Co-authored-by: Josh Gross <joshmgross@github.com>

Co-authored-by: Josh Gross <joshmgross@github.com>
2020-05-12 17:48:36 +02:00
dependabot[bot] 73e90b0167 Bump @actions/http-client from 1.0.7 to 1.0.8 in /packages/artifact (#437)
Bumps [@actions/http-client](https://github.com/actions/http-client) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/actions/http-client/releases)
- [Changelog](https://github.com/actions/http-client/blob/master/RELEASES.md)
- [Commits](https://github.com/actions/http-client/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-05-01 11:32:41 +02:00
Konrad Pabjan db6523742b E2E tests for the @actions/artifact package (#421)
* End-to-end artifact tests

* E2E tests for artifact package
2020-04-23 20:52:53 +02:00
Konrad Pabjan fc8de62ae1 @actions/artifact 0.3.1 update (#420)
* Updates to 0.3.1 package update
2020-04-20 22:58:53 +02:00
Pierre Grimaud ad730db8dc Fix typos (#417) 2020-04-20 12:56:03 +02:00
Konrad Pabjan 0eb6f58b7e @actions/artifact package updates (#408)
* Clear error message when storage quota has been hit

* Improved download of empty files

* Extra info to RELEASES.md

* PR Feedback
2020-04-09 17:14:12 +02:00
Konrad Pabjan 9afb95c7e8 Updates to @actions/artifact (#396)
* Add support for 429s and Exponential backoff

* Refactor status-reporter so it can be used with download and upload

* Extra logs

* Fixes around download & gzip

* Cleanup headers and add extra tests

* Improved Docs

* Spelling bloopers

* Improved error messages

* User http client version 1.0.7
2020-04-08 16:55:18 +02:00
Konrad Pabjan b1587dfcdf Contribution guidelines for artifact package (#388)
* Contribution guidelines
* PR Feedback
2020-03-24 10:13:06 +01:00
Konrad Pabjan 5c6ee206c1 Update implementation-details.md 2020-03-20 18:42:18 +01:00
Konrad Pabjan 5bbc71a6b8 Update additional-information.md 2020-03-19 15:56:27 +01:00
Konrad Pabjan eca624a5b2 Update package-lock.json 2020-03-12 20:39:10 +01:00