Remove inaccurate Prometheus metrics
The metrics include: - weave_packets_total - weave_bytes_total The problem with those metrics is that fastdp periodically flushes flows including their stats thus makes the current implementation of the metrics unreliable.
This commit is contained in:
1 parent
2cd3bde348
commit
b1d6605e8f
1 file changed
-12
@@ -76,18 +76,6 @@ var metrics []metric = []metric{
|
||||
ch <- intGauge(desc, metrics.Flows)
|
||||
}
|
||||
}},
|
||||
{desc("weave_packets_total", "Number of packets transferred.", "flow"),
|
||||
func(s WeaveStatus, desc *prometheus.Desc, ch chan<- prometheus.Metric) {
|
||||
if metrics := fastDPMetrics(s); metrics != nil {
|
||||
ch <- uint64Counter(desc, metrics.TotalPackets, "total")
|
||||
}
|
||||
}},
|
||||
{desc("weave_bytes_total", "Number of bytes transferred.", "flow"),
|
||||
func(s WeaveStatus, desc *prometheus.Desc, ch chan<- prometheus.Metric) {
|
||||
if metrics := fastDPMetrics(s); metrics != nil {
|
||||
ch <- uint64Counter(desc, metrics.TotalBytes, "total")
|
||||
}
|
||||
}},
|
||||
}
|
||||
|
||||
func fastDPMetrics(s WeaveStatus) *weave.FastDPMetrics {
|
||||
|
||||
Reference in new issue
Block a user