Matthias Radestock
2284bc2120
move error response construction to handler
...
and implement it in terms of existing functions, plus provide a
convenience method for sending the rather common NameError.
2015-08-21 12:09:22 +01:00
Matthias Radestock
0b5f5fd74e
extract response writing
2015-08-20 20:24:12 +01:00
Matthias Radestock
9a7abe68fd
optimise response construction when no truncation is required
...
no need to do a binary search if all the answers fit
2015-08-20 20:18:56 +01:00
Matthias Radestock
2ea27ec08f
simplify response truncation
2015-08-20 19:55:19 +01:00
Matthias Radestock
322441d5c8
inline truncateResponse
2015-08-20 19:55:19 +01:00
Matthias Radestock
7c7c302920
extract response construction
2015-08-20 19:17:03 +01:00
Matthias Radestock
69986e77dd
cosmetic
2015-08-20 18:46:55 +01:00
Matthias Radestock
8182022d52
refactor dns handlers
...
introduce a handler struct, which
- enables lifting of all the handle* closures to methods
- eliminates the passing around of defaultMaxResponseSize
- reduces the number of free-floating functions
2015-08-20 18:27:58 +01:00
Matthias Radestock
f399c3a888
Merge branch '1.0'
...
Conflicts:
ipam/ring/ring_test.go
2015-08-20 16:32:09 +01:00
Matthias Radestock
79d1c404a7
Merge pull request #1342 from weaveworks/1336-fix-ring-fuzztest
...
Fix ring fuzz-test
Fixes #1336 .
2015-08-20 16:25:50 +01:00
Adam Harrison
1e83e7a95c
Merge branch '1.0'
2015-08-20 15:33:59 +01:00
Adam Harrison
086ab9d126
Correct MaxUDPPacketSize constant
2015-08-20 15:22:10 +01:00
Bryan Boreham
135c34a45a
Don't remove peer from table until after we've copied its entries out
2015-08-20 13:11:51 +01:00
Bryan Boreham
ca6e54890c
Fix Transfer() when removing a peer, so we actually target the other peer.
2015-08-20 13:11:51 +01:00
Tom Wilkie
dac219b64a
Merge pull request #1339 from weaveworks/revert-1338-1336-check-len
...
Revert "In ipam ring unit test, check if we have any peers with entri…
2015-08-20 12:23:06 +01:00
Tom Wilkie
790a1757e0
Revert "In ipam ring unit test, check if we have any peers with entries to avoid crash "
2015-08-20 12:18:34 +01:00
Tom Wilkie
aafa0f6783
Merge pull request #1338 from weaveworks/1336-check-len
...
In ipam ring unit test, check if we have any peers with entries to avoid crash
2015-08-20 12:15:27 +01:00
Bryan Boreham
df5426dd8b
Check if we have any peers with entries, to avoid crash
2015-08-20 11:57:56 +01:00
Adam Harrison
3803d79835
Merge pull request #1335 from weaveworks/1328_handle_invalid_status_sub_command
...
better error handling for invalid `weave status` sub-command
2015-08-20 11:48:01 +01:00
Matthias Radestock
ceff3bed28
better error handling for invalid weave status sub-command
...
instead of showing '404 page not found'
Fixes #1328 .
2015-08-20 11:14:59 +01:00
Matthias Radestock
eebdbe226b
Merge pull request #1325 from weaveworks/1322_handle_usage_locally
...
deal with `weave --help|help` locally
Fixes #1322 .
2015-08-20 10:13:45 +01:00
Matthias Radestock
8ab639ddaa
deal with weave --help|help locally
...
thus making them unaffected by docker breakages
Fixes #1322 .
2015-08-20 10:03:21 +01:00
Matthias Radestock
812579a139
Merge pull request #1326 from weaveworks/576_better_version_check
...
better docker version check
Fixes #576 .
2015-08-19 21:31:43 +01:00
Matthias Radestock
08f31886d6
better docker version check
...
Fixes #567 . Supersedes #1298 .
2015-08-19 21:20:14 +01:00
Matthias Radestock
f080e5aa5c
Merge pull request #1331 from weaveworks/clarify-test-160
...
clarify test 160
2015-08-19 20:41:59 +01:00
Matthias Radestock
d61c719e45
cosmetic
2015-08-19 20:39:16 +01:00
Bryan Boreham
4d49bf3ab9
Add comment to clarify the reason why there is no explicit 'assert' test at the end.
2015-08-19 16:54:24 +01:00
Matthias Radestock
f34f837106
Merge branch '1.0'
...
Conflicts:
weave
2015-08-19 16:38:55 +01:00
Matthias Radestock
1326994a6d
Merge pull request #1319 from weaveworks/dns-tcp
...
Expose dns server on tcp as well as udp
Fixes #1333 .
2015-08-19 16:34:09 +01:00
Matthias Radestock
99ab0d3abc
Merge branch '1.0'
2015-08-19 11:29:23 +01:00
Matthias Radestock
e61f9afb72
Merge pull request #1330 from weaveworks/1329_plug_gossip_sender_leak
...
plug GossipSender leak
Fixes #1329 .
2015-08-19 11:26:25 +01:00
Matthias Radestock
29c64b1f40
document weave env --restore
...
leftover from #1327
2015-08-19 11:20:10 +01:00
Bryan Boreham
db51b772b4
Merge pull request #1327 from weaveworks/1288_restore_env
...
Closes #1288
2015-08-19 10:54:43 +01:00
Matthias Radestock
0b764a2a27
plug GossipSender leak
...
GossipChannel.sendDown is the (only) place which creates
GossipSenders. It has two call sites, Send and SendDown, only the
former of which performed a gc of existing senders. Therefore, in
configurations with
- a lot of connection churn, and
- SendDown invocations for these connections, and
- few or no Send invocations
we can leak GossipSenders.
The most likely scenario for this to occur is a peer that, while
having no other connections, is making/accepting connections which get
torn down post handshake, e.g. because IPAM detected a clash.
Fixes #1329 .
2015-08-19 10:22:11 +01:00
Matthias Radestock
a93a3e98b9
warn when stopping proxy when the env is using it
2015-08-18 18:08:02 +01:00
Matthias Radestock
be94dcc8a3
introduce weave env --restore
...
`weave env` stashes the existing DOCKER_HOST in ORIG_DOCKER_HOST, and
`weave env --restore` sets DOCKER_HOST to $ORIG_DOCKER_HOST.
Closes #1288 .
2015-08-18 17:20:21 +01:00
Matthias Radestock
a34b31ad12
refactor: make proxy_addr more single purpose
2015-08-18 15:40:58 +01:00
Matthias Radestock
e1d07aa264
cosmetic
2015-08-18 15:34:43 +01:00
Matthias Radestock
0d79a8fc43
cosmetic
2015-08-18 15:08:59 +01:00
Matthias Radestock
5d1411830b
Merge branch '1.0'
2015-08-18 13:33:36 +01:00
Matthias Radestock
dc91ce9ec6
Merge branch 'latest_release_doc_updates' into 1.0
2015-08-18 13:33:15 +01:00
Matthias Radestock
36a857f343
remove "Contact information" link on docs home page
...
It's broken, and we have a link in the footer anyway.
Fixes #1260 .
2015-08-18 13:31:28 +01:00
Matthias Radestock
c1c5450caf
more idiomatic logger initialisation, with standard default log level
2015-08-18 12:04:48 +01:00
Bryan Boreham
0b4e8b8754
Merge pull request #1318 from weaveworks/1305_suppress_self_reconnection
...
lgtm. Fixes #1305 .
2015-08-18 11:14:15 +01:00
Matthias Radestock
f73dcba306
eliminate spurious warning when --ipalloc-range=""
...
Fixes #1320 .
2015-08-18 09:50:42 +01:00
Ilya Dmitrichenko
147a537b82
We are not using gcloud, but it cause a conflict
...
https://s3.amazonaws.com/archive.travis-ci.org/jobs/76062893/log.txt
2015-08-18 09:47:37 +01:00
Ilya Dmitrichenko
a4844b8ee7
We are not using gcloud, but it cause a conflict
...
https://s3.amazonaws.com/archive.travis-ci.org/jobs/76062893/log.txt
2015-08-18 09:46:09 +01:00
Ilya Dmitrichenko
acde6cb0ee
We are not using gcloud, but it cause a conflict
...
https://s3.amazonaws.com/archive.travis-ci.org/jobs/76062893/log.txt
2015-08-18 09:40:03 +01:00
Paul Bellamy
b4e13215c7
expose dns server on tcp as well as udp
...
issue was discovered when testing scope with master vs 1.0 branches.
2015-08-18 09:35:53 +01:00
Matthias Radestock
4ecaa0f508
don't put blank lines around sub-status
...
not what I had in mind, and it breaks the tests
2015-08-18 09:00:01 +01:00