Commit Graph
1525 Commits
Author SHA1 Message Date
Adam Harrison be05cec1b0 Ensure at least one CIDR is supplied to multi-CIDR commands 2015-04-17 11:38:46 +01:00
Adam Harrison f17cd6ac3b Convert hide to use collect_cidr_args 2015-04-17 11:37:28 +01:00
Adam Harrison 2332bc9a94 Require minimum Vagrant version (1.7.0) in smoke tests 2015-04-17 11:07:53 +01:00
Matthias Radestock 803821ab2c we need arping in the vagrant vm, for weave --local to work 2015-04-17 10:22:08 +01:00
Matthias Radestock 1cd31fd090 only invoke create_bridge once in expose/hide 2015-04-16 18:19:15 +01:00
Matthias Radestock 705dda9d3e cosmetic: remove outdated comment 2015-04-16 18:19:00 +01:00
Matthias Radestock 19da213dab refactor: more shell magic, for consistency 2015-04-16 18:00:18 +01:00
Matthias Radestock 779b69c0f6 correct usage for expose+hide
Hangover from #498.
2015-04-16 17:49:17 +01:00
rade 8f4d894a77 Merge pull request #566 from awh/name_exposed_addresses_in_weavedns
Add optional hostname argument to weave expose

Closes #375.
2015-04-16 17:45:47 +01:00
Adam Harrison 4d941338fd Add optional hostname argument to weave expose 2015-04-16 15:19:01 +01:00
rade af51aef33f Merge pull request #551 from rade/weave_port
make weave port configurable via WEAVE_PORT
2015-04-16 14:44:39 +01:00
Bryan Boreham 36b13b704d Merge pull request #565 from rade/515_crypto_glitch_stall
Big improvement in observed behaviour.  LGTM; closes #515
2015-04-16 12:08:02 +01:00
Matthias Radestock a5a91ebb33 do not shut down connections on PacketDecodingError 2015-04-15 21:52:56 +01:00
Matthias Radestock f4ba0f7287 log udp packet processing errors against the connection 2015-04-15 21:10:22 +01:00
Matthias Radestock 57b7276ceb create forwarders before AddConnection, if we can
This is beneficial for reasons explained in the comments. And we used
to do that previously, when initHeartbeats was called before
AddConnection.
2015-04-15 20:55:42 +01:00
Matthias Radestock 9b25815641 don't send heartbeats on new but ultimately invalid connections
It is wasteful and can trip up crypto at the other end. See comment
for why.

To accomplish this we move the responsibility for shutting down the
new, invalid connection from LocalPeer.AddConnection to its caller,
i.e. LocalConnection.run. So rather than always firing up all the
connection machinery and getting told asynchronously by AddConnection
to shut it all down again, we now only fire it up if AddConnection
succeeded.
2015-04-15 20:04:40 +01:00
Matthias Radestock a9963675b6 remove dead code 2015-04-15 16:13:18 +01:00
rade 0ccf19e488 Merge pull request #561 from dpw/random-mac
Make the first byte of the generated bridge MAC more random
2015-04-15 15:43:57 +01:00
David Wragg a1db1e11f5 Make the first byte of the generated bridge MAC more random 2015-04-15 14:19:28 +01:00
rade 2eb13f0020 Merge pull request #558 from awh/weave_ps_includes_exposed_addresses
Include weave exposed addresses in ps output

Closes #385.
2015-04-15 12:01:30 +01:00
Adam Harrison cbbe3cc122 Include weave exposed addresses in ps output 2015-04-15 11:54:05 +01:00
rade ab49eb42fb Merge pull request #555 from rade/478_more_discriminate_connectivity
more discriminate connectivity

Closes #478.
2015-04-15 11:48:23 +01:00
Matthias Radestock 339f85cbcb get rid of Router.NormalisePeerAddr
There was only one call site left and it always gets invoked with an
ip:port, so normalisation is a no-op.

Also remove mysterious comment.
2015-04-15 11:44:48 +01:00
Matthias Radestock 290d5443cc more discriminate connectivity
If a peer was specified on the command line w/o a port, then do not
connect to it if we have inbound connections from that IP.

This eliminates unnecessary (and ultimately failing) connection
attempts in the common scenario of several peers having been told
about each other on their command lines.

We represent a command line peer address with a TCPAddr, which avoids
back and forth conversion to string and extra fields to carry the "did
the original include a port?" information.
2015-04-15 11:42:53 +01:00
rade 9bd2afc6c3 Merge pull request #560 from rade/include_remote_address_in_connection_logging
always include the remote address in connection log entries
tidy up / declutter some log and status output
2015-04-15 11:23:26 +01:00
Matthias Radestock 9478696d1a update example output in docs 2015-04-15 11:17:30 +01:00
Matthias Radestock 5415e3a60a drop "Peer " prefix in Peers section of status
it's redundant and the output looks much better w/o it
2015-04-15 11:09:35 +01:00
Matthias Radestock f0998d6196 declutter status' reconnects section 2015-04-15 10:56:29 +01:00
Matthias Radestock f6def13ea9 change style for connections in status' reconnects section
to match how they are shown in the logs
2015-04-15 10:55:14 +01:00
Matthias Radestock b1fd1334b4 always include the remote address in connection log entries
in addition to the peer name

This is handy for debugging, especially in situations when there are
multiple connections in flight to the same peer.
2015-04-14 22:14:29 +01:00
Matthias Radestock 74b3bf8299 pass on args in multiweave launch <args>... 2015-04-14 19:22:01 +01:00
Matthias Radestock f9ea3f54d1 Merge branch 'bboreham-make-tests-stop'
Closes #557
2015-04-14 18:03:42 +01:00
Bryan Boreham 8c6c14c6d3 Accumulate any errors from go test commands so we can report overall status 2015-04-14 18:03:10 +01:00
Matthias Radestock 31775a8b84 cosmetic 2015-04-14 17:58:13 +01:00
Matthias Radestock 973996184d fix bug 2015-04-14 13:27:10 +01:00
Bryan Boreham d334b903e4 Merge pull request #556 from rade/do_not_duplicate_router_config
LGTM
2015-04-14 12:58:05 +01:00
Matthias Radestock 798bfeb0a7 make the Router include the RouterConfig
rather than copying the bulk of it
2015-04-14 11:39:11 +01:00
rade 9b29d2ecc5 Merge pull request #554 from dpw/main-routerconfig
Pull forward the declaration of the RouterConfig in main()
2015-04-14 10:57:43 +01:00
Matthias Radestock 961801b792 refactor: shrink function by extracting helpers 2015-04-14 06:49:47 +01:00
David Wragg ae00582212 Reintroduce a bufSzMB variable 2015-04-13 22:29:19 +01:00
David Wragg 1213935030 Pull forward the declaration of the RouterConfig in main()
This eliminates a few variables, and the naming awkardness where we
have corresponding but distinct flag and router config variables.
2015-04-13 21:39:15 +01:00
Matthias Radestock c2972b7558 cosmetic: remove dead code 2015-04-13 21:28:07 +01:00
rade 9833747fd9 Merge pull request #553 from dpw/makefile-cleanups
Makefile cleanups
2015-04-13 21:05:32 +01:00
David Wragg 1328f8bec7 Use $(@D) rather than $(shell dirname $@) 2015-04-13 20:50:50 +01:00
David Wragg 433d406d83 Use $(@D) rather than $(shell dirname $@) 2015-04-13 20:39:01 +01:00
David Wragg bc9bb9e4ae tempfile is a deprecated debianism
As noted in its man page.
2015-04-13 20:37:12 +01:00
Matthias Radestock 805005e632 weave status no longer complains about missing weaveDNS 2015-04-13 18:28:52 +01:00
Matthias Radestock 202f536e07 refactor: extract some helpers in order to shrink main() 2015-04-13 16:03:49 +01:00
Matthias Radestock b062facbe9 refactor: inline 2015-04-13 15:56:52 +01:00
rade a80b8eacac Merge pull request #552 from bboreham/status-conn-errors
Allow ConnectionMaker to report the reason the connection broke
2015-04-13 15:46:09 +01:00