Travis insists that one picks a project language. There is no go left
in the steps executed by travis. Instead we have Python, Ruby and
shell. Let's pick the first...
Picking Python makes travis unhappy with "Can not perform a '--user'
install. User site-packages are not visible in this
virtualenv". Dropping the '--user' flag fixes that.
(cherry picked from commit 1d8d098450)
There is no point running builds, tests, lints on Travis, since we
already do that on Circle.
The only thing we aren't doing (and can't do) on Circle is doc
publishing, so now Travis does just that.
(cherry picked from commit 1038cbd1a3)
Invoke the new create_veth from a few places, eliminating code
duplication and inconsistencies.
Semantic differences:
- init_bridged_fastdp now skips the veth creation/config if the veth
already exists. This eliminates routing blips. Though in reality
something very strange must have happened to end up in this code
with an existing veth.
- init_bridged_fastdp no longer deletes the $BRIDGE and $DATAPATH when
veth creation/configuration fails. This is consistent with
init_bridge, which does not delete $BRIDGE when something goes
wrong. And it is generally desirable since the init_* functions are
invoked on potentially existing bridges - e.g. following 'weave
stop'.
- attach_bridge and setup_router_iface_bridge used to mark one veth
end 'up', then invoke add_iface_* for it, and then mark the other
end 'up'. create_veth marks both ends 'up' first. This makes no
practical difference in these cases.
notable other differences:
- we detect veth presence by checking whether *both* ends are present,
rather than just one. We deliberately continue to (and fail in) the
veth creation if one end already exists. This can only happen when
we've stumbled across a different interface, since a veth end cannot
exist independently. So it is right to treat this as an error.
- init_bridged_fastdp invokes add_iface_bridge instead of duplicating
what that does. Also makes for nice coherence with the
add_iface_fastdp it is invoking too.
Ilya Dmitrichenko