refactor: don't extract param to var and shift unless we have to

This commit is contained in:
Matthias Radestock committed 2014-10-24 12:57:35 +01:00
1 parent 6501934a15
commit 5b6a892c38
1 file changed
+5 -10
+5 -10
View File
@@ -301,10 +301,9 @@ case "$COMMAND" in
;;
start)
[ $# -gt 1 ] || usage
IPADDR=$1
create_bridge
CONTAINER=$(docker start $2)
with_container_netns $CONTAINER attach $IPADDR $CONTAINER_IFNAME
with_container_netns $CONTAINER attach $1 $CONTAINER_IFNAME
echo $CONTAINER
;;
attach)
@@ -318,22 +317,18 @@ case "$COMMAND" in
;;
expose)
[ $# -gt 0 ] || usage
IPADDR=$1
shift 1
create_bridge
if ! ip addr show dev $BRIDGE | grep -qF $IPADDR
if ! ip addr show dev $BRIDGE | grep -qF $1
then
ip addr add dev $BRIDGE $IPADDR
ip addr add dev $BRIDGE $1
fi
;;
hide)
[ $# -gt 0 ] || usage
IPADDR=$1
shift 1
create_bridge
if ip addr show dev $BRIDGE | grep -qF $IPADDR
if ip addr show dev $BRIDGE | grep -qF $1
then
ip addr del dev $BRIDGE $IPADDR
ip addr del dev $BRIDGE $1
fi
;;
stop)