Fix returns when iterating over Connections()

d5eb76f32 replaced (*Peer)ForEachConnection into (*Peer)Connections(),
and consequently converted some nested functions into for loops.  But
the "return" statements in those nested functions were left as-was,
and so exited the outer function rather than moving on to the next
iteration.

Fixes #497

router/connection_maker.go

@@ -136,7 +136,7 @@ func (cm *ConnectionMaker) checkStateAndAttemptConnections() time.Duration {
 		for _, conn := range peer.Connections() {
 			otherPeer := conn.Remote().Name
 			if otherPeer == cm.ourself.Name || ourConnectedPeers[otherPeer] {
-				return
+				continue
 			}
 			address := conn.RemoteTCPAddr()
 			// try both portnumber of connection and standard port.  Don't use remote side of inbound connection.

router/routes.go

@@ -132,11 +132,11 @@ func (routes *Routes) calculateBroadcast() map[PeerName][]PeerName {
 			// locking.
 			for _, conn := range ourself.Connections() {
 				if !conn.Established() {
-					return
+					continue
 				}
 				remoteName := conn.Remote().Name
 				if _, found := reached[remoteName]; found {
-					return
+					continue
 				}
 				if remoteConn, found := conn.Remote().ConnectionTo(ourself.Name); found && remoteConn.Established() {
 					hops = append(hops, remoteName)